Fix citation ref → refs to support multi-citation clusters#93
Merged
gvonness-apolitical merged 1 commit intomainfrom Feb 16, 2026
Merged
Fix citation ref → refs to support multi-citation clusters#93gvonness-apolitical merged 1 commit intomainfrom
gvonness-apolitical merged 1 commit intomainfrom
Conversation
Change Citation.reference (String) to Citation.refs (Vec<String>) per spec, enabling multi-citation clusters like [smith2023; jones2024]. - Custom Serialize/Deserialize on Citation accepting both "ref" (string) and "refs" (array) for backward compatibility - ExtensionMark::citation/citation_with_page now emit "refs" array - Add multi_citation(), get_citation_refs(), normalize_citation_attrs() - Add get_string_array_attribute() on both ExtensionMark and ExtensionBlock - Bump version to 0.6.0 (breaking API + wire format change)
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Citation.reference(String) →Citation.refs(Vec) to match spec and enable multi-citation clusters like[smith2023; jones2024]Serialize/DeserializeonCitationaccepting both old"ref"(string) and new"refs"(array) for backward compatibilityExtensionMark::citation()/citation_with_page()now emit"refs"arraymulti_citation(),get_string_array_attribute(),get_citation_refs(),normalize_citation_attrs()helpersTest plan
cargo test --workspace --all-features— 1030 tests passcargo clippy --workspace --all-features -- -D warnings— zero warnings{"ref":"smith2023"}deserializes correctly intorefs: ["smith2023"]{"refs":["smith2023","jones2024"]}survives serialize → deserializenormalize_citation_attrs()rewrites legacy"ref"→"refs"in-place